Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust msal-browser log messages #3589

Merged
merged 11 commits into from
May 10, 2021
Merged

Adjust msal-browser log messages #3589

merged 11 commits into from
May 10, 2021

Conversation

jo-arroyo
Copy link
Collaborator

@jo-arroyo jo-arroyo commented May 6, 2021

In verbose mode, log messages from msal-browser seem excessively long. This PR changes logs in the BrowserCacheManager to a new lower logLevel Trace so Verbose logs are less noisy but we are still able to debug cache miss issues if necessary.

@github-actions github-actions bot added the msal-browser Related to msal-browser package label May 6, 2021
@coveralls
Copy link

coveralls commented May 6, 2021

Coverage Status

Coverage decreased (-0.04%) to 83.768% when pulling 05839cc on browser-remove-excess-logs into 9d70339 on dev.

@jo-arroyo jo-arroyo marked this pull request as ready for review May 7, 2021 20:50
Copy link
Member

@hectormmg hectormmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jo-arroyo jo-arroyo requested a review from sameerag as a code owner May 10, 2021 19:05
@github-actions github-actions bot added the msal-common Related to msal-common package label May 10, 2021
@jasonnutter jasonnutter merged commit 73ec6b5 into dev May 10, 2021
@jasonnutter jasonnutter deleted the browser-remove-excess-logs branch May 10, 2021 20:37
pkanher617 pushed a commit to pkanher617/microsoft-authentication-library-for-js that referenced this pull request Dec 30, 2021
azure-pipelines bot pushed a commit to pkanher617/microsoft-authentication-library-for-js that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants