Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CCS parameters to headers or form_data #3636

Merged
merged 27 commits into from Jun 28, 2021
Merged

Add CCS parameters to headers or form_data #3636

merged 27 commits into from Jun 28, 2021

Conversation

pkanher617
Copy link
Contributor

This PR adds the CCS (Cache Credential Service) parameters to the headers or form_data when the login_hint or account object are available.

It also introduces a configuration parameter to prevent adding headers when CORS preflight requests can be prevented.

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels May 13, 2021
@coveralls
Copy link

coveralls commented May 14, 2021 •
edited

Coverage Status

Coverage decreased (-2.7%) to 81.084% when pulling 11f7ea9 on ccs-feature into b42e87f on dev.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021 •
edited

Codecov Report

Merging #3636 (9ab2e72) into dev (e57cbfc) will decrease coverage by 0.42%.
The diff coverage is 62.09%.

Flag Coverage Δ *Carryforward flag
msal-angular 96.05% <ø> (ø)
msal-browser 84.27% <65.62%> (-0.38%) ⬇️
msal-common 82.24% <60.86%> (-1.17%) ⬇️
msal-core 73.02% <ø> (ø) Carriedforward from 378fba9
msal-node 78.35% <ø> (ø)
msal-react 93.77% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
lib/msal-common/src/config/ClientConfiguration.ts 100.00% <ø> (ø)
lib/msal-common/src/client/RefreshTokenClient.ts 68.13% <28.57%> (-7.82%) ⬇️
...wser/src/interaction_handler/InteractionHandler.ts 71.11% <40.00%> (-15.99%) ⬇️
.../msal-common/src/client/AuthorizationCodeClient.ts 76.96% <51.35%> (-8.35%) ⬇️
lib/msal-common/src/client/BaseClient.ts 68.29% <53.84%> (-7.57%) ⬇️
...browser/src/interaction_handler/RedirectHandler.ts 89.83% <60.00%> (-2.77%) ⬇️
...ib/msal-common/src/cache/entities/AccountEntity.ts 74.15% <75.00%> (+0.29%) ⬆️
...b/msal-common/src/client/UsernamePasswordClient.ts 90.47% <75.00%> (-1.84%) ⬇️
lib/msal-browser/src/app/ClientApplication.ts 90.62% <100.00%> (ø)
lib/msal-browser/src/cache/BrowserCacheManager.ts 93.69% <100.00%> (+0.12%) ⬆️
... and 9 more

@pkanher617 pkanher617 marked this pull request as ready for review May 27, 2021 23:52
sameerag
sameerag reviewed May 28, 2021
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, will check next week once we confirm all node cases are addressed. Thanks.

jasonnutter
jasonnutter approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing overwise looks good!

@github-actions github-actions bot added the samples Related to the samples apps for the library. label Jun 18, 2021
@tnorling tnorling added this to the @azure/msal-browser@2.15.0 milestone Jun 22, 2021
sameerag
sameerag approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sameerag sameerag merged commit 3edff73 into dev Jun 28, 2021
@sameerag sameerag deleted the ccs-feature branch June 28, 2021 22:37
@ghost
Copy link

ghost commented Jun 29, 2021

🎉@azure/msal-common@v4.4.0 has been released which incorporates this pull request.:tada:

We recommend upgrading to the latest version of @azure/msal-browser or @azure/msal-node to take advantage of this change.

Handy links:

@ghost
Copy link

ghost commented Jun 29, 2021

🎉@azure/msal-browser@v2.15.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@tnorling tnorling tnorling approved these changes

@sameerag sameerag sameerag approved these changes

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@samuelkubai samuelkubai Awaiting requested review from samuelkubai

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package samples Related to the samples apps for the library.
Projects
None yet
Milestone
@azure/msal-browser@2.15.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pkanher617 @coveralls @codecov-commenter @jasonnutter @tnorling @sameerag