Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msal-node]: Add regional authorities telemetry #3662

Merged
merged 42 commits into from
Jul 7, 2021
Merged

[msal-node]: Add regional authorities telemetry #3662

merged 42 commits into from
Jul 7, 2021

Conversation

samuelkubai
Copy link
Contributor

@samuelkubai samuelkubai commented May 20, 2021 •
edited
Loading

Upgrade the server telemetry schema to version 5.

  • Add telemetry on regional authorities

@github-actions github-actions bot added msal-common Related to msal-common package msal-node Related to msal-node package labels May 20, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.493% when pulling 42b33d2 on regional-authorities-telemetry into 0b9f138 on dev.

tnorling
tnorling reviewed May 26, 2021
View reviewed changes
lib/msal-common/src/authority/Authority.ts Outdated Show resolved Hide resolved
lib/msal-common/src/authority/Authority.ts Outdated Show resolved Hide resolved
lib/msal-common/src/authority/Authority.ts Outdated Show resolved Hide resolved
lib/msal-common/src/telemetry/server/ServerTelemetryManager.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2021 •
edited
Loading

Codecov Report

Merging #3662 (0dbf971) into dev (c9d7d77) will decrease coverage by 0.12%.
The diff coverage is 61.01%.

Flag Coverage Δ *Carryforward flag
msal-angular 95.65% <ø> (ø)
msal-browser 84.27% <ø> (ø)
msal-common 81.88% <60.34%> (-0.44%) ⬇️
msal-core 73.02% <ø> (ø) Carriedforward from ac9a7fd
msal-node 80.06% <100.00%> (+0.03%) ⬆️
msal-react 93.77% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
lib/msal-common/src/authority/RegionDiscovery.ts 45.71% <33.33%> (-0.72%) ⬇️
...b/msal-common/src/client/ClientCredentialClient.ts 77.61% <50.00%> (-4.93%) ⬇️
lib/msal-common/src/client/OnBehalfOfClient.ts 68.67% <50.00%> (-0.84%) ⬇️
lib/msal-common/src/client/SilentFlowClient.ts 88.00% <71.42%> (-6.60%) ⬇️
...mon/src/telemetry/server/ServerTelemetryManager.ts 91.95% <83.33%> (-2.65%) ⬇️
lib/msal-node/src/client/ClientApplication.ts 74.71% <100.00%> (+0.29%) ⬆️

@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package msal-react Related to @azure/msal-react labels Jun 29, 2021
tnorling
tnorling reviewed Jun 29, 2021
View reviewed changes
Copy link
Collaborator

@tnorling tnorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My last suggestions...I promise :) Looks great otherwise!

lib/msal-common/src/client/SilentFlowClient.ts Outdated Show resolved Hide resolved
lib/msal-common/src/telemetry/server/ServerTelemetryManager.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot removed extensions Related to extensions for the base libraries msal-browser Related to msal-browser package msal-react Related to @azure/msal-react labels Jun 30, 2021
sameerag
sameerag requested changes Jun 30, 2021
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us clean up the detectRegion API a little before we check this in. Everything else looks good.

@samuelkubai
fix: cleanup the region discovery api
2a7da53 
- improve the readability of the region discovery API
@samuelkubai
Copy link
Contributor Author

Let us clean up the detectRegion API a little before we check this in. Everything else looks good.

I have cleaned up the section in question and improved it's readability.

@samuelkubai
refactor: improve code readability of the RegionDiscovery file
ac9a7fd 
- improve code readability of the RegionDiscovery file
- add code comments in the RegionDiscovery file
@samuelkubai
fix: replace the auto discover flag with the flag from the .NET team
0dbf971
@github-actions github-actions bot added the documentation Related to documentation. label Jul 1, 2021
sameerag
sameerag approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samuelkubai samuelkubai merged commit 79dfa3e into dev Jul 7, 2021
@samuelkubai samuelkubai deleted the regional-authorities-telemetry branch July 7, 2021 10:15
@ghost
Copy link

ghost commented Jul 22, 2021

🎉@azure/msal-node@v1.3.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 22, 2021

🎉@azure/msal-common@v4.5.0 has been released which incorporates this pull request.:tada:

We recommend upgrading to the latest version of @azure/msal-browser or @azure/msal-node to take advantage of this change.

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter left review comments

@tnorling tnorling tnorling approved these changes

@sameerag sameerag sameerag approved these changes

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@pkanher617 pkanher617 Awaiting requested review from pkanher617

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

Assignees
No one assigned
Labels
documentation Related to documentation. msal-angular Related to @azure/msal-angular package msal-common Related to msal-common package msal-node Related to msal-node package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@samuelkubai @coveralls @codecov-commenter @jasonnutter @tnorling @sameerag