Discard tokens acquired after current time #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
*This pull request uses carry forward flags. Click here to find out more.
|
jasonnutter
approved these changes
Jun 22, 2021
sameerag
approved these changes
Jun 28, 2021
|
🎉 We recommend upgrading to the latest version of Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user turns back their system clock after a token is acquired they can potentially prolong the amount of time that MSAL will return a cached token to them even though the token may no longer be valid. This PR fixes this behavior by comparing the token
cachedAttime to the current time and forcing a refresh if the current time is earlier than the cached at time. This is in accordance with the unified cache schema spec.Fixes #3206