New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update in-progress temporary cache in v1 #4014
Conversation
Codecov Report
*This pull request uses carry forward flags. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 Handy links: |
🎉 Handy links: |
Today in both msal.js v1 and v2 the in-progress temporary cache entry is bound to the clientId which invoked the interaction. This means that if your page is running multiple instances of msal interactive requests will not be blocked by ongoing interactive requests by another instance. This is particularly problematic when using redirects as only 1 redirect can happen at a given time.
This PR, along with #4015, makes several changes to make the multi-instance interaction scenario more robust:
sessionStorage
for parity with v2 (for now only the interaction in progress cache item is moved)clientId
from the interaction in progress cache keyclientId
that invoked interactionThe cache key/value will be standard (
msal.interaction.status
) for both v1 and v2 to help with migration efforts.