Fix circular dependencies in AuthenticationHeaderParser and AsyncMemoryStorage

[hectormmg]

This PR:

• Changes the ClientAuthError import in AuthenticationHeaderParser from "../index.ts" to "../error/ClientAuthError.ts"
• Changes the BrowserAuthError import in AsyncMemoryStorage from "../index.ts" to "../error/BrowserAuthError"
• Changes the Logger import in AsyncMemoryStorage from "../index.ts" to "@azure/msal-common"

[jasonnutter]

Interesting that typescript doesn't catch this...is this breaking the library right now?

[hectormmg]

Interesting that typescript doesn't catch this...is this breaking the library right now?

@jasonnutter not just that, the circular dependency was actually added by VS Code's "Quick fix..." import option

[tnorling]

Looks like there's a lint rule we could use to catch this in the future: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-cycle.md

[codecov-commenter]

Codecov Report

Merging #4235 (4faf8f9) into dev (13a7548) will not change coverage.
The diff coverage is 100.00%.

Flag	Coverage Δ		*Carryforward flag
msal-angular	96.39% <ø> (ø)
msal-browser	87.77% <100.00%> (ø)
msal-common	85.41% <100.00%> (ø)
msal-core	77.07% <ø> (ø)		Carriedforward from 13a7548
msal-node	81.93% <ø> (ø)
msal-react	94.19% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
lib/msal-browser/src/cache/AsyncMemoryStorage.ts	68.18% <100.00%> (ø)
...l-common/src/request/AuthenticationHeaderParser.ts	100.00% <100.00%> (ø)

[ghost]

🎉@azure/msal-browser@v2.20.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Official NPM Release

[ghost]

🎉@azure/msal-common@v5.2.0 has been released which incorporates this pull request.:tada:

We recommend upgrading to the latest version of @azure/msal-browser or @azure/msal-node to take advantage of this change.

Handy links:

• Release Notes
• Official NPM Release