Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling in device-code #5033

Merged
merged 7 commits into from Aug 1, 2022
Merged

Add error handling in device-code #5033

merged 7 commits into from Aug 1, 2022

Conversation

sameerag
Copy link
Member

Add error handling for deviceCodeClient use cases where the server may crash/polling may have failed for unexpected reasons.

Addresses PR #4507

@github-actions github-actions bot added the msal-common Related to msal-common package label Jul 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #5033 (253f0f9) into dev (2c028d8) will not change coverage.
The diff coverage is 75.00%.

Flag Coverage Δ *Carryforward flag
msal-angular 96.50% <ø> (ø)
msal-browser 86.69% <ø> (ø)
msal-common 85.26% <75.00%> (ø) Carriedforward from 2c028d8
msal-core 82.84% <ø> (ø) Carriedforward from 2c028d8
msal-node 82.99% <ø> (ø)
msal-node-extensions 76.03% <ø> (ø)
msal-react 94.50% <ø> (ø)
node-token-validation 88.88% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
lib/msal-common/src/error/AuthError.ts 93.75% <ø> (ø)
lib/msal-common/src/client/DeviceCodeClient.ts 85.00% <75.00%> (ø)

@sameerag sameerag marked this pull request as ready for review August 1, 2022 17:47
@sameerag sameerag merged commit 86166e7 into dev Aug 1, 2022
@sameerag sameerag deleted the devicecode-error-handling branch August 1, 2022 21:39
@ghost
Copy link

ghost commented Aug 1, 2022

🎉@azure/msal-common@v7.3.0 has been released which incorporates this pull request.:tada:

We recommend upgrading to the latest version of @azure/msal-browser or @azure/msal-node to take advantage of this change.

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-common Related to msal-common package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[msal-common] DeviceCodeClient not properly throwing if the server errors during polling
4 participants