Extend msal-browser TokenCache loadExternalTokens to load refresh tokens #5233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvalentine
requested review from
sameerag,
tnorling,
peterzenz,
bgavrilMS and
jasonnutter
as code owners
ghost
assigned 
github-actions
bot
added
msal-browser
added 2 commits
September 21, 2022 11:32
…en and return account id
lvalentine
force-pushed
the
user/louisv/external_load_refresh_tokens
branch
from
06e27c7
to
879f28f
Compare
jasonnutter
reviewed
Sep 22, 2022
jasonnutter
reviewed
Sep 22, 2022
|
@lvalentine Please run |
jasonnutter
reviewed
Sep 26, 2022
change/@azure-msal-browser-321fc9fc-e44c-4168-8b90-7b77291857d1.json
Outdated
Show resolved
Hide resolved
jasonnutter
reviewed
Sep 26, 2022
change/@azure-msal-common-4922da53-5379-4871-ab08-329b7ada9d93.json
Outdated
Show resolved
Hide resolved
Codecov Report
*This pull request uses carry forward flags. Click here to find out more.
|
…1.json Co-authored-by: Jason Nutter <jasonnutter@outlook.com>
….json Co-authored-by: Jason Nutter <jasonnutter@outlook.com>
jasonnutter
reviewed
Sep 26, 2022
|
One more comment on style, otherwise looks great, thanks for addressing feedback! |
added 2 commits
September 27, 2022 09:31
…thub.com/lvalentine/microsoft-authentication-library-for-js into user/louisv/external_load_refresh_tokens
hectormmg
requested changes
Sep 27, 2022
…to build cache record
lvalentine
requested review from
hectormmg and
jasonnutter
and removed request for
jo-arroyo and
hectormmg
hectormmg
reviewed
Sep 28, 2022
hectormmg
approved these changes
Sep 28, 2022
jasonnutter
approved these changes
Sep 30, 2022
tnorling
reviewed
Sep 30, 2022
tnorling
approved these changes
Oct 10, 2022
|
🎉 We recommend upgrading to the latest version of Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends the
TokenCache.loadExternalTokensmethod to support loading refresh tokens. It also makes a few small changes inTokenCacheto make it easier to use this functionality from an application:TokenCache.loadExternalTokensnow returns aAuthenticationResultfor the response that was loaded. This allows the calling code to easily get access to the newly loaded account without having to know anything about how msal creates the account id from the Request/Response that was loaded (ie. fromIPublicClientApplication.getAccountByHomeId).TokenCache.loadIdTokengenerates thehomeAccountIdfrom the request to match the same method used inNativeInteractionClient, usingAccountEntity.generateHomeAccountId. This change was made so that the tokens that are initially side loaded via theTokenCache.loadExternalTokensmethod can be found in the cache and refreshed when acquiring access tokens via a supported path likeIPublicClientApplication.acquireTokenSilent.