Make popup poll interval configurable #5276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y to every 30ms to avoid issues with URL hash disappearing before MSAL can evaluate it
hectormmg
requested review from
jasonnutter,
tnorling,
peterzenz and
jo-arroyo
as code owners
github-actions
bot
added
documentation
github-actions
bot
removed
the
msal-angular
Codecov Report
*This pull request uses carry forward flags. Click here to find out more.
|
tnorling
approved these changes
Oct 4, 2022
| constructor(authCodeModule: AuthorizationCodeClient, storageImpl: BrowserCacheManager, authCodeRequest: CommonAuthorizationCodeRequest, logger: Logger, navigateFrameWait: number) { | ||
| private pollIntervalMilliseconds: number; | ||
|
|
||
| constructor(authCodeModule: AuthorizationCodeClient, storageImpl: BrowserCacheManager, authCodeRequest: CommonAuthorizationCodeRequest, logger: Logger, systemOptions: Required<Pick<BrowserSystemOptions, "navigateFrameWait" | "pollIntervalMilliseconds">>) { |
There was a problem hiding this comment.
Make sure this change also gets addressed in 1P
jasonnutter
approved these changes
Oct 4, 2022
|
🎉 Handy links: |
azure-pipelines bot
pushed a commit
that referenced
this pull request
Feb 2, 2023
* Reduce default polling interval to 30ms * Update angular v2 doc references * Make poll interval configurable and increase default polling frequency to every 30ms to avoid issues with URL hash disappearing before MSAL can evaluate it * Undo angular doc changes * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: