Add additional telemetry for WAM bridge #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-library-for-js into add-static-fields-telemetry
tnorling
requested review from
sameerag,
peterzenz and
bgavrilMS
as code owners
github-actions
bot
added
msal-browser
peterzenz
approved these changes
Oct 17, 2022
Codecov Report
*This pull request uses carry forward flags. Click here to find out more.
|
sameerag
reviewed
Oct 19, 2022
| matsAccountJoinOnStart: mats ? mats.account_join_on_start : undefined, | ||
| matsAccountJoinOnEnd: mats ? mats.account_join_on_end : undefined, | ||
| matsDeviceJoin: mats ? mats.device_join : undefined, | ||
| matsPromptBehavior: mats ? mats.prompt_behavior : undefined, |
There was a problem hiding this comment.
Is all MATS data considered static?
There was a problem hiding this comment.
Yes, we only get MATS data back once per request
sameerag
approved these changes
Oct 19, 2022
tnorling
requested review from
hectormmg,
jo-arroyo and
Robbie-Microsoft
as code owners
|
🎉 Handy links: |
|
🎉 We recommend upgrading to the latest version of Handy links: |
azure-pipelines bot
pushed a commit
that referenced
this pull request
Feb 2, 2023
* Add static fields to telemetry * resolve merge conflicts * restore removed params * Fix tests * Change files * Update RefreshTokenClient.spec.ts * add mats fields to telemetry * fix test * restore API surface for performance callback * Change files
azure-pipelines bot
pushed a commit
that referenced
this pull request
Feb 2, 2023
* Add static fields to telemetry * resolve merge conflicts * restore removed params * Fix tests * Change files * Update RefreshTokenClient.spec.ts * add mats fields to telemetry * fix test * restore API surface for performance callback * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional fields to our telemetry when going through the native broker.
Replaces #5098
This follows #5224