Include original request params on /token request in acquireTokenInteractive #5403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnorling
requested review from
sameerag,
hectormmg,
bmahall,
peterzenz,
jennyf19,
jmprieur,
bgavrilMS and
Robbie-Microsoft
as code owners
Codecov Report
*This pull request uses carry forward flags. Click here to find out more.
|
derisen
reviewed
Nov 17, 2022
| @@ -17,6 +17,7 @@ export const TEST_CONSTANTS = { | |||
| REDIRECT_URI: "http://localhost:8080", | |||
| CLIENT_SECRET: "MOCK_CLIENT_SECRET", | |||
| DEFAULT_GRAPH_SCOPE: ["user.read"], | |||
| DEFAULT_OIDC_SCOPES: ["openid", "profile", "offline_access"], | |||
There was a problem hiding this comment.
would it be better to import this from msal-common (OIDC_DEFAULT_SCOPES)
derisen
approved these changes
Nov 17, 2022
It's a new feature, not sure how much usage it has gotten yet. |
sameerag
approved these changes
Nov 21, 2022
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in
acquireTokenInteractiveresulted in providedscopesand other request parameters being ignored on the/tokenrequest. This PR ensures that the/tokenrequest parameters match the parameters from the/authorizerequestFixes #5390