Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigate noAccountError #2098678 #5529

Merged
merged 2 commits into from Jan 4, 2023
Merged

Mitigate noAccountError #2098678 #5529

merged 2 commits into from Jan 4, 2023

Conversation

konstantin-msft
Copy link
Collaborator

  • Log number of accounts in trace mode.
  • Validate that getActiveAccount() picks up legacy account identifier from local storage.

@konstantin-msft konstantin-msft changed the title Mitigate noAccountError #2098678 Mitigate noAccountError #2098678 Jan 4, 2023
@github-actions github-actions bot added the msal-browser Related to msal-browser package label Jan 4, 2023
@konstantin-msft konstantin-msft marked this pull request as ready for review January 4, 2023 23:06
@konstantin-msft konstantin-msft merged commit 4ed1f69 into dev Jan 4, 2023
@konstantin-msft konstantin-msft deleted the 2098678_mitigate_missing_acc_in_storage branch January 4, 2023 23:36
@ghost
Copy link

ghost commented Jan 10, 2023

🎉@azure/msal-browser@v2.32.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorling tnorling tnorling approved these changes

@bmahall bmahall bmahall approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@konstantin-msft @tnorling @bmahall