Update ProtectedResourceScopes type to allow unprotected resource for… #5563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… concrete request type In the Interceptor documentation (https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-angular/docs/v2-docs/msal-interceptor.md), it is stated that it should be possible to use scope value 'null' to indicate that the resource should be unprotected, even only for the concrete request type. This Pull requests ensures that the typing follows such logic.
budmil
requested review from
jo-arroyo,
tnorling and
peterzenz
as code owners
ghost
assigned 
|
Thank you for your contribution! Please generate change files by running |
|
@budmil thanks for catching this -could you please go through beachball check |
|
@microsoft-github-policy-service agree [company="freiheit.software"] |
|
@microsoft-github-policy-service agree company="freiheit.software" |
Codecov Report
*This pull request uses carry forward flags. Click here to find out more. |
derisen
approved these changes
Jan 20, 2023
jo-arroyo
approved these changes
Jan 20, 2023
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… concrete request type
In the Interceptor documentation (https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-angular/docs/v2-docs/msal-interceptor.md), it is stated that it should be possible to use scope value 'null' to indicate that the resource should be unprotected, even only for the concrete request type. This Pull requests ensures that the typing follows such logic.