Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rxjs dev dependency for MSAL Angular #6004

Merged
merged 8 commits into from May 10, 2023
Merged

Update rxjs dev dependency for MSAL Angular #6004

merged 8 commits into from May 10, 2023

Conversation

jo-arroyo
Copy link
Collaborator

@jo-arroyo jo-arroyo commented May 10, 2023 •
edited

Updates RxJS dev dependency for MSAL Angular to allow e2e tests to run properly.

@github-actions github-actions bot added the msal-angular Related to @azure/msal-angular package label May 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023 •
edited

Codecov Report

Merging #6004 (babe7ff) into dev (81d34b4) will increase coverage by 11.74%.
The diff coverage is 96.63%.

Flag Coverage Δ
msal-angular 96.73% <96.63%> (+0.22%) ⬆️
msal-browser ?
msal-common ?
msal-core ?
msal-node ?
msal-node-extensions ?
msal-react ?
node-token-validation ?
Impacted Files Coverage Δ
lib/msal-angular/src/msal.guard.ts 90.78% <90.78%> (+0.64%) ⬆️
lib/msal-angular/src/msal.navigation.client.ts 93.33% <92.85%> (+0.47%) ⬆️
lib/msal-angular/src/constants.ts 100.00% <100.00%> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <100.00%> (ø)
lib/msal-angular/src/msal.interceptor.ts 100.00% <100.00%> (ø)
lib/msal-angular/src/msal.module.ts 100.00% <100.00%> (ø)
lib/msal-angular/src/msal.redirect.component.ts 100.00% <100.00%> (ø)
lib/msal-angular/src/msal.service.ts 100.00% <100.00%> (ø)
lib/msal-angular/src/packageMetadata.ts 100.00% <100.00%> (ø)

... and 225 files with indirect coverage changes

@jo-arroyo jo-arroyo marked this pull request as ready for review May 10, 2023 00:31
@jo-arroyo jo-arroyo merged commit 3458e00 into dev May 10, 2023
19 checks passed
@jo-arroyo jo-arroyo deleted the msal-angular-rxjs-update branch May 10, 2023 17:29
@ghost
Copy link

ghost commented May 17, 2023

🎉@azure/msal-angular@v3.0.0-alpha.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorling tnorling tnorling approved these changes

@peterzenz peterzenz peterzenz approved these changes

Assignees
No one assigned
Labels
msal-angular Related to @azure/msal-angular package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jo-arroyo @codecov-commenter @tnorling @peterzenz