-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified refreshOn in MSAL Common Silent Flow to return cached token before refreshing in the background #6397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oken when the token needs to be refreshed
Robbie-Microsoft
requested review from
sameerag,
tnorling,
hectormmg,
peterzenz,
jennyf19,
jmprieur,
bgavrilMS,
jo-arroyo and
konstantin-msft
as code owners
August 25, 2023 17:46
github-actions
bot
added
msal-node
Related to msal-node package
msal-common
Related to msal-common package
labels
Aug 25, 2023
Robbie-Microsoft
changed the title
Modified refreshOn in MSAL Common Silent Flow to also return cached token
Modified refreshOn in MSAL Common Silent Flow to return cached token before refreshing in the background
Aug 25, 2023
Robbie-Microsoft
requested review from
trwalke,
pmaytak,
gladjohn,
neha-bhargava,
rayluo and
Avery-Dunn
as code owners
August 29, 2023 21:01
bgavrilMS
reviewed
Sep 1, 2023
bgavrilMS
reviewed
Sep 1, 2023
bgavrilMS
requested changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No sleep in tests; Errors must be actionable.
pmaytak
approved these changes
Sep 7, 2023
bgavrilMS
approved these changes
Sep 8, 2023
sameerag
reviewed
Sep 8, 2023
konstantin-msft
approved these changes
Sep 8, 2023
sameerag
approved these changes
Sep 8, 2023
pmaytak
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
msal-browser
Related to msal-browser package
msal-common
Related to msal-common package
msal-node
Related to msal-node package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refreshOn functionality already exists in Silent Flow. That is, if a token needs to be refreshed but is not expired, an error was thrown and the token was refreshed. This PR contains changes that will now return the cached token if it needs to be refreshed and is not expired, while also refreshing the token in the background.