Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add v2.0 to authority endpoint if already exists #6457

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

konstantin-msft
Copy link
Collaborator

  • Do not add v2.0 to authority endpoint if already exists.

@github-actions github-actions bot added the msal-common Related to msal-common package label Sep 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Merging #6457 (7cc5a5a) into dev (81d34b4) will decrease coverage by 2.01%.
Report is 310 commits behind head on dev.
The diff coverage is 61.03%.

Flag Coverage Δ
msal-angular 96.73% <ø> (+0.22%) ⬆️
msal-browser 85.32% <ø> (-1.15%) ⬇️
msal-common 82.83% <ø> (-1.72%) ⬇️
msal-core ?
msal-node 80.16% <ø> (-3.23%) ⬇️
msal-node-extensions 68.51% <60.77%> (-7.13%) ⬇️
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Files Changed Coverage Δ
...ions/msal-node-extensions/src/utils/Environment.ts 20.51% <0.00%> (-22.08%) ⬇️
lib/msal-angular/src/constants.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts 90.78% <ø> (+0.64%) ⬆️
lib/msal-angular/src/msal.interceptor.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.module.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.navigation.client.ts 93.33% <ø> (+0.47%) ⬆️
lib/msal-angular/src/msal.redirect.component.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/packageMetadata.ts 100.00% <ø> (ø)
... and 70 more

... and 161 files with indirect coverage changes

Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage docs mention to always pass only domainname/tenantId format. Curious about the usage here, it is good to have but recommend the proper usage as much as possible.

@hectormmg
Copy link
Member

Usage docs mention to always pass only domainname/tenantId format. Curious about the usage here, it is good to have but recommend the proper usage as much as possible.

I agree that the developer shouldn't be setting the API version, but I also prefer we gracefully avoid duplication rather than throw if the7 set v2.0/

@konstantin-msft konstantin-msft force-pushed the fix_authority_endpoint_versioning branch 4 times, most recently from 4d6b992 to f30c87e Compare September 12, 2023 15:08
@konstantin-msft konstantin-msft merged commit 19eed25 into dev Sep 12, 2023
35 of 44 checks passed
@konstantin-msft konstantin-msft deleted the fix_authority_endpoint_versioning branch September 12, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-common Related to msal-common package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in metadata discovery after upgrading msal-common v13.1.0 to v14.0.2
5 participants