Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing queue measurement instrumentation #6480

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Add missing queue measurement instrumentation #6480

merged 3 commits into from
Sep 15, 2023

Conversation

konstantin-msft
Copy link
Collaborator

@konstantin-msft konstantin-msft commented Sep 14, 2023 •
edited

  • Add missing queue measurement instrumentation.
  • Default queue time to 0 for manually completed queue events.
  • Update unit tests.

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels Sep 14, 2023
@konstantin-msft konstantin-msft force-pushed the fix_queue_measurement_instrumentation branch from 9e3e17b to 76be051 Compare September 14, 2023 20:01
@konstantin-msft konstantin-msft marked this pull request as ready for review September 14, 2023 20:05
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023 •
edited

Codecov Report

Merging #6480 (d490ed6) into dev (81d34b4) will decrease coverage by 1.73%.
Report is 321 commits behind head on dev.
The diff coverage is 60.25%.

Flag Coverage Δ
msal-angular 96.73% <ø> (+0.22%) ⬆️
msal-browser 85.43% <ø> (-1.04%) ⬇️
msal-common 83.73% <ø> (-0.81%) ⬇️
msal-core ?
msal-node 80.24% <ø> (-3.15%) ⬇️
msal-node-extensions 67.53% <60.00%> (-8.11%) ⬇️
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Files Changed Coverage Δ
...ions/msal-node-extensions/src/utils/Environment.ts 20.51% <0.00%> (-22.08%) ⬇️
lib/msal-angular/src/constants.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts 90.78% <ø> (+0.64%) ⬆️
lib/msal-angular/src/msal.interceptor.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.module.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.navigation.client.ts 93.33% <ø> (+0.47%) ⬆️
lib/msal-angular/src/msal.redirect.component.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/packageMetadata.ts 100.00% <ø> (ø)
... and 65 more

... and 171 files with indirect coverage changes

sameerag
sameerag reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we can identify when addQueueMeasurement is not called when it is supposed to?

@konstantin-msft
Copy link
Collaborator Author

Is there any way we can identify when addQueueMeasurement is not called when it is supposed to?

We can do that by checking the number of manually completed queue events, which is, unfortunately, non-proactive.

@konstantin-msft konstantin-msft force-pushed the fix_queue_measurement_instrumentation branch from 78fee29 to a914427 Compare September 15, 2023 21:15
@konstantin-msft
- Add missing queue measurement instrumentation.
3d99f3b 
- Add `performanceClient` to `BrowserCacheManager` constructor.
- Default queue time to 0 for manually completed queue events.
- Update unit tests.
@konstantin-msft
Change files
e4756d5
@konstantin-msft
- Address review comments.
d490ed6
@konstantin-msft konstantin-msft force-pushed the fix_queue_measurement_instrumentation branch from a914427 to d490ed6 Compare September 15, 2023 21:55
@konstantin-msft konstantin-msft enabled auto-merge (squash) September 15, 2023 22:06
@konstantin-msft konstantin-msft merged commit a9af309 into dev Sep 15, 2023
43 of 44 checks passed
@konstantin-msft konstantin-msft deleted the fix_queue_measurement_instrumentation branch September 15, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorling tnorling tnorling approved these changes

@sameerag sameerag sameerag approved these changes

@peterzenz peterzenz peterzenz approved these changes

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@konstantin-msft @codecov-commenter @tnorling @sameerag @peterzenz