Add getAccount and enhance account filtering

[hectormmg]

This PR:

• Adds and accountFilter: AccountFilter param to getAllAccounts() in order to enable the narrowing-down of cached accounts returned
• Adds getAccountByFilter API to replace now marked-for-deprecation getAccountBy APIs
• Extends AccountFilter class to optionally include all the properties in AccountInfo except idToken and idTokenClaims so accounts are filterable by all of their searchable properties
• Adds new AccountFilter properties to the set of matchers in CacheManager.getAccountsFilteredBy() as well as their respective private matching methods
• Adds filtering by loginHint

[codecov-commenter]

Codecov Report

Merging #6499 (90e87ce) into dev (81d34b4) will decrease coverage by 1.24%.
Report is 329 commits behind head on dev.
The diff coverage is 61.03%.

Flag	Coverage Δ
msal-angular	96.73% <ø> (+0.22%)	⬆️
msal-browser	85.43% <ø> (-1.04%)	⬇️
msal-common	84.73% <ø> (+0.19%)	⬆️
msal-core	?
msal-node	80.75% <ø> (-2.64%)	⬇️
msal-node-extensions	68.51% <60.77%> (-7.13%)	⬇️
msal-react	94.24% <ø> (-0.45%)	⬇️
node-token-validation	?

Files	Coverage Δ
extensions/msal-node-extensions/src/Dpapi.ts	100.00% <100.00%> (ø)
.../msal-node-extensions/src/error/NativeAuthError.ts	100.00% <100.00%> (ø)
extensions/msal-node-extensions/src/index.ts	100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/packageMetadata.ts	100.00% <100.00%> (+100.00%)	⬆️
...-extensions/src/persistence/DataProtectionScope.ts	100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/utils/Constants.ts	100.00% <100.00%> (ø)
...sions/msal-node-extensions/src/utils/TypeGuards.ts	100.00% <100.00%> (ø)
lib/msal-angular/src/constants.ts	100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts	100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts	90.78% <ø> (+0.64%)	⬆️
... and 57 more

... and 184 files with indirect coverage changes

[tnorling]

A couple nits but otherwise looks great! Thanks for doing this!

[sameerag]

Minor comments, approved. Much clear now, Thanks.

[sameerag]

Should we add this to all test tokens? We can take it as a new item in the backlog.

[hectormmg]

We could, but cred scan only flags new credentials it finds in the diff

[Nodios]

Hi,

Just a quick question regarding this change. Is there a reason why the interface IPublicClientApplication was not updated with the method definition changes? I don't know if I'm missing something

See example below:

Interface

microsoft-authentication-library-for-js/lib/msal-browser/src/app/IPublicClientApplication.ts

Line 49 in d055ad8

getAllAccounts(): AccountInfo[];

Implementation

microsoft-authentication-library-for-js/lib/msal-browser/src/app/PublicClientApplication.ts

Line 245 in d055ad8

getAllAccounts(accountFilter?: AccountFilter): AccountInfo[] {