Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address missing params in refreshtoken flow #6504

Merged
merged 25 commits into from
Oct 2, 2023
Merged

Address missing params in refreshtoken flow #6504

merged 25 commits into from
Oct 2, 2023

Conversation

sameerag
Copy link
Member

@sameerag sameerag commented Sep 21, 2023 •
edited

  • Address missing params in acquireTokenByRefreshToken for specific flows
  • Correct request thumbprint clientId in AuthorizationCodeClient and RefreshTokenClient

@github-actions github-actions bot added the msal-browser Related to msal-browser package label Sep 21, 2023
@sameerag sameerag changed the title Login ssosilent support pwb Add InteractionType: SsoSilent Sep 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023 •
edited

Codecov Report

Merging #6504 (08b870f) into dev (81d34b4) will decrease coverage by 1.21%.
Report is 335 commits behind head on dev.
The diff coverage is 61.03%.

Flag Coverage Δ
msal-angular 96.73% <ø> (+0.22%) ⬆️
msal-browser 85.44% <ø> (-1.03%) ⬇️
msal-common 84.69% <ø> (+0.14%) ⬆️
msal-core ?
msal-node 81.02% <ø> (-2.37%) ⬇️
msal-node-extensions 68.51% <60.77%> (-7.13%) ⬇️
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Files Coverage Δ
extensions/msal-node-extensions/src/Dpapi.ts 100.00% <100.00%> (ø)
.../msal-node-extensions/src/error/NativeAuthError.ts 100.00% <100.00%> (ø)
extensions/msal-node-extensions/src/index.ts 100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/packageMetadata.ts 100.00% <100.00%> (+100.00%) ⬆️
...-extensions/src/persistence/DataProtectionScope.ts 100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/utils/Constants.ts 100.00% <100.00%> (ø)
...sions/msal-node-extensions/src/utils/TypeGuards.ts 100.00% <100.00%> (ø)
lib/msal-angular/src/constants.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts 90.78% <ø> (+0.64%) ⬆️
... and 48 more

... and 192 files with indirect coverage changes

@github-actions github-actions bot added the msal-common Related to msal-common package label Sep 24, 2023
@sameerag sameerag changed the title Add InteractionType: SsoSilent Add support for ssoSilent type, address bugs in acquireTokenByRefreshToken Sep 24, 2023
@sameerag sameerag changed the title Add support for ssoSilent type, address bugs in acquireTokenByRefreshToken Add support for ssoSilent type, address missing params in refresh_token grant Sep 24, 2023
@sameerag sameerag marked this pull request as ready for review September 24, 2023 07:32
@sameerag sameerag marked this pull request as draft September 24, 2023 07:33
@sameerag sameerag changed the title Add support for ssoSilent type, address missing params in refresh_token grant Address missing params in refrehtoken flow Sep 27, 2023
@sameerag sameerag changed the title Address missing params in refrehtoken flow Address missing params in refreshtoken flow Sep 27, 2023
@sameerag sameerag marked this pull request as ready for review September 27, 2023 21:04
@sameerag sameerag merged commit bfdd254 into dev Oct 2, 2023
45 checks passed
@sameerag sameerag deleted the login-ssosilent-support-pwb branch October 2, 2023 18:23
@matzehecht matzehecht mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectormmg hectormmg hectormmg approved these changes

@peterzenz peterzenz peterzenz approved these changes

@lalimasharda lalimasharda lalimasharda approved these changes

@konstantin-msft konstantin-msft konstantin-msft approved these changes

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sameerag @codecov-commenter @hectormmg @peterzenz @lalimasharda @konstantin-msft