-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument Crypto APIs #6512
Merged
Merged
Instrument Crypto APIs #6512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnorling
requested review from
sameerag,
hectormmg,
jo-arroyo,
peterzenz,
Robbie-Microsoft and
konstantin-msft
as code owners
September 25, 2023 23:19
github-actions
bot
added
msal-browser
Related to msal-browser package
msal-common
Related to msal-common package
labels
Sep 25, 2023
tnorling
requested review from
bgavrilMS,
trwalke,
pmaytak,
gladjohn,
neha-bhargava,
rayluo and
Avery-Dunn
as code owners
September 25, 2023 23:40
peterzenz
approved these changes
Sep 25, 2023
sameerag
reviewed
Sep 27, 2023
sameerag
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment on function names imports, approved.
konstantin-msft
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
msal-browser
Related to msal-browser package
msal-common
Related to msal-common package
msal-node
Related to msal-node package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PkceGenerator
andBrowserCrypto
classes into pure functions for better minification and simpler usage