Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument Crypto APIs #6512

Merged
merged 9 commits into from
Sep 27, 2023
Merged

Instrument Crypto APIs #6512

merged 9 commits into from
Sep 27, 2023

Conversation

tnorling
Copy link
Collaborator

  • Adds instrumentation for Crypto APIs, specifically around PKCE generation
  • Also refactors PkceGenerator and BrowserCrypto classes into pure functions for better minification and simpler usage

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels Sep 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Merging #6512 (06a1147) into dev (81d34b4) will decrease coverage by 1.24%.
Report is 330 commits behind head on dev.
The diff coverage is 61.03%.

Flag Coverage Δ
msal-angular 96.73% <ø> (+0.22%) ⬆️
msal-browser 85.41% <ø> (-1.06%) ⬇️
msal-common 84.72% <ø> (+0.17%) ⬆️
msal-core ?
msal-node 80.80% <ø> (-2.59%) ⬇️
msal-node-extensions 68.51% <60.77%> (-7.13%) ⬇️
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Files Coverage Δ
extensions/msal-node-extensions/src/Dpapi.ts 100.00% <100.00%> (ø)
.../msal-node-extensions/src/error/NativeAuthError.ts 100.00% <100.00%> (ø)
extensions/msal-node-extensions/src/index.ts 100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/packageMetadata.ts 100.00% <100.00%> (+100.00%) ⬆️
...-extensions/src/persistence/DataProtectionScope.ts 100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/utils/Constants.ts 100.00% <100.00%> (ø)
...sions/msal-node-extensions/src/utils/TypeGuards.ts 100.00% <100.00%> (ø)
lib/msal-angular/src/constants.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts 90.78% <ø> (+0.64%) ⬆️
... and 53 more

... and 187 files with indirect coverage changes

Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on function names imports, approved.

@tnorling tnorling merged commit 781325b into dev Sep 27, 2023
28 of 44 checks passed
@tnorling tnorling deleted the instrument-crypto-apis branch September 27, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants