Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "inlineDynamicImports" to rollup config to fix CJS build. Make factory methods basic functions #6615

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Add "inlineDynamicImports" to rollup config to fix CJS build. Make factory methods basic functions #6615

merged 2 commits into from
Oct 30, 2023

Conversation

konstantin-msft
Copy link
Collaborator

  • Add "inlineDynamicImports" to rollup config to fix CJS build.
  • Make factory methods basic functions.

@github-actions github-actions bot added the msal-browser Related to msal-browser package label Oct 27, 2023
@konstantin-msft konstantin-msft marked this pull request as ready for review October 27, 2023 19:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023 •
edited

Codecov Report

Merging #6615 (d37910e) into dev (81d34b4) will decrease coverage by 4.13%.
Report is 365 commits behind head on dev.
The diff coverage is n/a.

Flag Coverage Δ
msal-angular 96.73% <ø> (+0.22%) ⬆️
msal-browser 79.12% <ø> (-7.35%) ⬇️
msal-common ?
msal-core ?
msal-node ?
msal-node-extensions ?
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Files Coverage Δ
lib/msal-angular/src/constants.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts 90.78% <ø> (+0.64%) ⬆️
lib/msal-angular/src/msal.interceptor.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.module.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.navigation.client.ts 93.33% <ø> (+0.47%) ⬆️
lib/msal-angular/src/msal.redirect.component.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/packageMetadata.ts 100.00% <ø> (ø)
...b/msal-browser/src/app/IPublicClientApplication.ts 41.17% <ø> (-2.58%) ⬇️
... and 51 more

... and 183 files with indirect coverage changes

@konstantin-msft konstantin-msft merged commit 9296e4b into dev Oct 30, 2023
30 of 31 checks passed
@konstantin-msft konstantin-msft deleted the fix_naa_cjs_build branch October 30, 2023 13:31
@konstantin-msft konstantin-msft linked an issue Oct 31, 2023 that may be closed by this pull request
Unable to run unit tests that reference MsalService #6596
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectormmg hectormmg hectormmg approved these changes

@tnorling tnorling tnorling approved these changes

@jo-arroyo jo-arroyo jo-arroyo approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to run unit tests that reference MsalService
5 participants
@konstantin-msft @codecov-commenter @hectormmg @tnorling @jo-arroyo