Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded metadata fetching for tenanted authorities #6622

Merged
merged 15 commits into from
Oct 30, 2023

Conversation

hectormmg
Copy link
Member

@hectormmg hectormmg commented Oct 28, 2023

This PR:

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Merging #6622 (c4e5b84) into dev (81d34b4) will decrease coverage by 4.15%.
Report is 370 commits behind head on dev.
The diff coverage is 60.81%.

Flag Coverage Δ
msal-angular 96.73% <ø> (+0.22%) ⬆️
msal-browser 79.04% <ø> (-7.43%) ⬇️
msal-common 83.85% <ø> (-0.70%) ⬇️
msal-core ?
msal-node 80.72% <ø> (-2.67%) ⬇️
msal-node-extensions 67.37% <60.55%> (-8.27%) ⬇️
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Files Coverage Δ
extensions/msal-node-extensions/src/Dpapi.ts 100.00% <100.00%> (ø)
.../msal-node-extensions/src/error/NativeAuthError.ts 100.00% <100.00%> (ø)
extensions/msal-node-extensions/src/index.ts 100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/packageMetadata.ts 100.00% <100.00%> (+100.00%) ⬆️
...-extensions/src/persistence/DataProtectionScope.ts 100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/utils/Constants.ts 100.00% <100.00%> (ø)
...sions/msal-node-extensions/src/utils/TypeGuards.ts 100.00% <100.00%> (ø)
lib/msal-angular/src/constants.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts 90.78% <ø> (+0.64%) ⬆️
... and 68 more

... and 182 files with indirect coverage changes

@github-actions github-actions bot added the msal-browser Related to msal-browser package label Oct 28, 2023
Copy link
Collaborator

@tnorling tnorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests we can add to msal-browser to validate this fixes the bug e2e?

@github-actions github-actions bot added the samples Related to the samples apps for the library. label Oct 30, 2023
@hectormmg
Copy link
Member Author

hectormmg commented Oct 30, 2023

Any tests we can add to msal-browser to validate this fixes the bug e2e?

@tnorling I duplicated the browserAAD E2E test and added a specific tenantId to the auth config. This tests the previously missed scenario since the acquireToken tests already reload the page between tests. I confirmed it fails on dev and passes here.

@hectormmg hectormmg merged commit c93777e into dev Oct 30, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package samples Related to the samples apps for the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session not persisting on page reload
4 participants