Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ServerTelemetryEntity from Class to Type #6651

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

tnorling
Copy link
Collaborator

@tnorling tnorling commented Nov 2, 2023

Continuation of the work to convert cache entities from classes to types and moving the related static methods to CacheHelpers namespace

@github-actions github-actions bot added msal-node Related to msal-node package msal-browser Related to msal-browser package msal-common Related to msal-common package labels Nov 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #6651 (2ce0744) into dev (81d34b4) will decrease coverage by 20.89%.
Report is 375 commits behind head on dev.
The diff coverage is 57.25%.

Flag Coverage Δ
msal-angular ?
msal-browser ?
msal-common ?
msal-core ?
msal-node ?
msal-node-extensions 64.11% <57.25%> (-11.54%) ⬇️
msal-react ?
node-token-validation ?
Files Coverage Δ
.../msal-node-extensions/src/error/NativeAuthError.ts 100.00% <100.00%> (ø)
extensions/msal-node-extensions/src/index.ts 100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/packageMetadata.ts 100.00% <100.00%> (+100.00%) ⬆️
...-extensions/src/persistence/DataProtectionScope.ts 100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/utils/Constants.ts 100.00% <100.00%> (ø)
...sions/msal-node-extensions/src/utils/TypeGuards.ts 100.00% <100.00%> (ø)
...msal-node-extensions/src/error/PersistenceError.ts 62.50% <66.66%> (-11.58%) ⬇️
...node-extensions/src/persistence/BasePersistence.ts 64.28% <50.00%> (-2.39%) ⬇️
extensions/msal-node-extensions/src/Dpapi.ts 33.33% <33.33%> (-66.67%) ⬇️
...tensions/src/persistence/PersistenceCachePlugin.ts 71.05% <55.55%> (-4.63%) ⬇️
... and 8 more

... and 215 files with indirect coverage changes

@tnorling tnorling merged commit 42a5e13 into dev Nov 2, 2023
44 of 46 checks passed
@tnorling tnorling deleted the serverTelemetryEntity-types branch November 2, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants