Fix MSAL cache cleaning method #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarylThayil
reviewed
May 1, 2019
DarylThayil
reviewed
May 1, 2019
|
few questions / comments but looks good to me |
DarylThayil
approved these changes
May 1, 2019
sameerag
reviewed
May 1, 2019
| // Cache account and authority | ||
| this.setAccountCache(account, serverAuthenticationRequest.state); | ||
| this.setAuthorityCache(serverAuthenticationRequest.state, acquireTokenAuthority.CanonicalAuthority); | ||
| this.updateAcquireTokenCacheEntries(serverAuthenticationRequest, account); |
There was a problem hiding this comment.
@pkanher617 As discussed you may want to combine the login calls caching code for "authority" and "nonce" also into this API. Please factor that login calls do not have "acquireTokenAccountKey".
There was a problem hiding this comment.
added to updateCacheEntries. Please check new code.
sameerag
reviewed
May 1, 2019
manoj-rath
reviewed
May 2, 2019
|
|
||
| // Cache account and authority | ||
| this.setAccountCache(account, serverAuthenticationRequest.state); | ||
| this.setAuthorityCache(serverAuthenticationRequest.state, acquireTokenAuthority.CanonicalAuthority); |
There was a problem hiding this comment.
it's canonicalAuthority here, however in the updateCacheEntries is using authority
|
|
||
| // Cache account and authority | ||
| this.setAccountCache(account, serverAuthenticationRequest.state); | ||
| this.setAuthorityCache(serverAuthenticationRequest.state, acquireTokenAuthority.CanonicalAuthority); |
There was a problem hiding this comment.
CanonicalAuthority - same as the other comment
|
lgtm approved |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for issue #527 where cache keys are not being cleared out.
A previous PR (#544) was submitted for this, but was failing some use cases. This fix works for manually tested use cases and passes all unit tests.