Instrument non-auth error name and stack #6937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstantin-msft
requested review from
sameerag,
tnorling,
hectormmg,
jo-arroyo,
peterzenz and
Robbie-Microsoft
as code owners
github-actions
bot
added
msal-browser
konstantin-msft
force-pushed
the
telemetry_add_stack_trace
branch
from
8ae2b4c
to
77fac4b
Compare
tnorling
reviewed
Mar 5, 2024
lib/msal-common/src/telemetry/performance/IPerformanceClient.ts
Outdated
Show resolved
Hide resolved
tnorling
reviewed
Mar 6, 2024
konstantin-msft
changed the title
tnorling
approved these changes
Mar 7, 2024
jo-arroyo
approved these changes
Mar 8, 2024
konstantin-msft
force-pushed
the
telemetry_add_stack_trace
branch
from
717d69a
to
cd8465a
Compare
- Capture non-auth errors in telemetry wrapper functions.
- Capture non-auth errors in telemetry wrapper functions.
- Capture non-auth errors in telemetry wrapper functions.
konstantin-msft
force-pushed
the
telemetry_add_stack_trace
branch
from
cd8465a
to
68f7962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note Non-auth errors make up 0.06% of the total errors so stack trace parsing/compacting won't impact perf. This number should get smaller once we sample and address non-auth errors.