Fix uncaught exceptions in acquireTokenSilent #7073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnorling
requested review from
sameerag,
hectormmg,
jo-arroyo,
peterzenz and
konstantin-msft
as code owners
tnorling
commented
May 1, 2024
change/@azure-msal-browser-94058809-8f02-4078-bdc6-02ff59c54ae3.json
Outdated
Show resolved
Hide resolved
konstantin-msft
approved these changes
May 1, 2024
konstantin-msft
force-pushed
the
address-uncaught-exception
branch
from
c90a869
to
ae208f6
Compare
jo-arroyo
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to optimize parallel iframed calls resulted in a regression that logged an uncaught exception to the console in the event that a single iframed call was made and failed. This happened because the stored promise rejected and didn't have a catch handler registered because there is not a parallel call dependent on this promise.
This PR resolves this issue by ensuring that the stored promise never rejects but rather resolves with a true/false indicating whether the call succeeded or failed.
Fixes #7052