Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove Utils.ts and make smaller Utility files #886

Merged
merged 2 commits into from Aug 2, 2019

Conversation

pkanher617
Copy link
Contributor

This is a continuation of efforts to refactor, this was an ask by @jasonnutter to make the Utils.ts file a little cleaner. This should be the last major change to our utils structure.

Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some whitespace inconsistencies, otherwise looks good!

Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@DarylThayil DarylThayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it lgtm

@DarylThayil DarylThayil merged commit fcf56a3 into dev Aug 2, 2019
@pkanher617 pkanher617 deleted the splitUtils-part2 branch August 8, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants