Do not merge : When rendered in an iframe, silent rejects #909
Conversation
... with an appropriate error. * Get rid of the decorator function because it is only used once * Add EnvironmentError * tests resolves #902
| return new EnvironmentError(code, desc); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
remove extra space
DarylThayil
changed the title
|
This causes issues with the way that pages are rerendered within popup on return from aad |
|
Is there a way I can help test this, as I get the code from a cdn normally and am not sure what to do here. I would have difficulty compiling and building this locally. |
|
@binaryjam no problem. I think there are unfortunately some architectural issues with that prevent us from making thing change right now @sameera is looking to remove the reliance on not allowing to be rendered in an iframe. Sameera this is something we should consider because when you remove the restriction, and the original app is rendered in the iframe to get the token response, there may be another ATS call and create an endless loop |
|
@DarylThayil Yes, I am considering that and indeed it is a well-known issue in ADAL which needed the developer to add a condition to prevent the loop, that was remedied by this decorator in MSAL. |
|
Closing, as this will be addressed by the work to support iframes in #899. |
... with an appropriate error.
resolves #902