update new var in configuration to allow user by pass URI check #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldalton
requested changes
Jul 23, 2020
| @@ -95,6 +95,12 @@ to target MSAL at a specific test slice & flight. These apply to all requests ma | |||
| */ | |||
| - (nonnull instancetype)initWithClientId:(NSString *)clientId; | |||
|
|
|||
| /** | |||
| Default is disable | |||
There was a problem hiding this comment.
Can you add a little bit more detailed comment such as developer would understand why it is needed?
There was a problem hiding this comment.
Address, I will update in next commit.
| { | ||
| return nil; | ||
| } | ||
|
|
||
| BOOL brokerCapable = [MSALRedirectUri redirectUriIsBrokerCapable:redirectURI]; | ||
| BOOL brokerCapable = !bypassRedirectValidation && [MSALRedirectUri redirectUriIsBrokerCapable:redirectURI]; |
There was a problem hiding this comment.
bypassing of Redirect URI validation shouldn't impact whether URL is broker capable.
There was a problem hiding this comment.
I thought we designed to forward the request to broker only when the redirectURI is verified? I might misunderstand the purpose of verifying redirectURI in MSAL.
There was a problem hiding this comment.
My bad, I've misread the code :) So this is to ensure that we don't forward request to broker, unless redirect was validated.
oldalton
approved these changes
Jul 24, 2020
hieunguyenmsft
added a commit
that referenced
this pull request
Jul 30, 2020
* update new var in configuration to allow user by pass URI check merge CHANGELOG
hieunguyenmsft
added a commit
that referenced
this pull request
Jul 30, 2020
* update new var in configuration to allow user by pass URI check merge to cherry-pick
This was referenced Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update MSAL Public configuration to allow user to enable bypass RedirectURI check for SSO Seeding feature.
Type of change
Risk
Additional information