Move jsonWebKey creation to key pair class for Cpp integration. #1018

rohitnarula7176 · 2020-07-27T19:34:22Z

Proposed changes

Move jsonWebKey creation logic to MSISAsymmetricKeyPair for Cpp team integration.

High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

MSAL/MSAL.xcodeproj/project.pbxproj

MSAL/test/app/ios/MSALTestAppCacheViewController.m

Move jsonWebKey creation to key pair class for Cpp integration

e1d6a21

rohitnarula7176 requested a review from a team as a code owner July 27, 2020 19:34

rohitnarula7176 requested review from aherciya, hieunguyenmsft and kevindiclemente July 27, 2020 19:34

rohitnarula7176 added 4 commits July 28, 2020 12:18

Add api to generate in-memory asymmetric key pair

8b34936

Update change log

a55b24b

Update deployment target to 10.12 for mac framework

03016f7

Add security framework dependency for mac unit tests

2011c39

oldalton approved these changes Jul 29, 2020

View reviewed changes

MSAL/MSAL.xcodeproj/project.pbxproj Show resolved Hide resolved

hieunguyenmsft reviewed Jul 29, 2020

View reviewed changes

MSAL/test/app/ios/MSALTestAppCacheViewController.m Show resolved Hide resolved

rohitnarula7176 added 6 commits July 29, 2020 13:10

Merge dev

3e98d5a

Update deployment targets for iOS and macOS

1ed3d6c

Update deprecated api for iOS10

2c4314a

Fix conflicts

bf39099

Update deprecated api for iOS10

ac6b434

Fix build

abee47f

rohitnarula7176 merged commit 98a6450 into dev Jul 30, 2020

rohitnarula7176 deleted the ronaru/jsonWebKey branch July 30, 2020 01:23