PRT refresh improvements #1019
Merged
PRT refresh improvements #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasoncoolmax
approved these changes
Jul 29, 2020
…m/AzureAD/microsoft-authentication-library-for-objc into oldalton/prt_refresh_improvements
mipetriu
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Current broker SDK uses a hardcoded PRT refresh interval of 4 or 12 hours. That might be insufficient if tenant has configured PRT to be valid for a much shorter period of time like 4 hours.
In order to correctly calculate PRT refresh interval related to PRT lifetime, introduce a cached property for PRT lifetime.
Type of change
Risk
Additional information