Hieund/sso seeding test app #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldalton
approved these changes
Jul 29, 2020
| @@ -76,7 +76,7 @@ @interface MSALTestAppAcquireTokenViewController () <UITextFieldDelegate> | |||
| @property (nonatomic) IBOutlet UIView *wkWebViewContainer; | |||
| @property (nonatomic) WKWebView *customWebview; | |||
| @property (weak, nonatomic) IBOutlet UISegmentedControl *authSchemeSegmentControl; | |||
|
|
|||
| @property NSString *accountIdentifier; | |||
There was a problem hiding this comment.
Address, will update in next commit.
| if (self.webviewTypeSegmentControl.selectedSegmentIndex == 0 && | ||
| self.customWebviewTypeSegmentControl.selectedSegmentIndex == TEST_EMBEDDED_WEBVIEW_CUSTOM) | ||
| { | ||
| [self.customWebview loadHTMLString:@"<html><head></head></html>" baseURL:nil]; |
There was a problem hiding this comment.
isn't this what is loading about:blank?
There was a problem hiding this comment.
These code is supposed to be called at the end of the flow (end of the 1st call if no ssoSeeding or end of the ssoSeeding call) so it should do no harm to the auth code grant flow.
I guess the old code purpose us to 'reset' that custom webview but not sure we still need it or not.
I will verify it today and make a new PR if that's redundant code can be removed.
jasoncoolmax
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update SSO Seeding feature in Test App.
To test it, add the profile with name "CompanyPortal" into profiles list.
For example:
@"CompanyPortal" : @{@"clientId" : @"b6c69a37-df96-4db0-9088-2ab96e1d8215",
@"redirectUri" : @"msalb6c69a37-df96-4db0-9088-2ab96e1d8215://auth"},
Type of change
Risk
Additional information