Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up test files from main targets #1046

Merged
merged 5 commits into from Aug 7, 2020
Merged

Cleaned up test files from main targets #1046

merged 5 commits into from Aug 7, 2020

Conversation

oldalton
Copy link
Member

@oldalton oldalton commented Aug 7, 2020

Proposed changes

There were a few unit test/mock files in the main product targets.
Removed them from targets.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@oldalton oldalton requested a review from a team as a code owner August 7, 2020 19:22
kaisong1990
kaisong1990 approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@kaisong1990 kaisong1990 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts :)

@oldalton oldalton merged commit 54f26a4 into dev Aug 7, 2020
@oldalton oldalton deleted the oldalton/file_cleanup branch August 7, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisong1990 kaisong1990 kaisong1990 approved these changes

@aherciya aherciya Awaiting requested review from aherciya

@hieunguyenmsft hieunguyenmsft Awaiting requested review from hieunguyenmsft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oldalton @kaisong1990