Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wiping external account #1085

Merged
merged 4 commits into from
Sep 10, 2020
Merged

Conversation

oldalton
Copy link
Member

@oldalton oldalton commented Sep 8, 2020

Proposed changes

In order to make sure user has a way to "forget" or "wipe" their account entry in cache, we need to add new API to MSAL to do so. This PR is a follow up PR for this one #1077, and it applies same wiping functionality to external account store.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@oldalton oldalton merged commit aa13a9c into dev Sep 10, 2020
@oldalton oldalton deleted the oldalton/forget_external_account branch September 10, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants