Remove identity core classes from public api

[antrix1989]

Proposed changes

We shouldn't have IdentityCore classes in the public API of MSAL.

Type of change

• Feature work
• Bug fix
• Documentation
• Engineering change
• Test
• Logging/Telemetry

Risk

• High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
• Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
• Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

[ameyapat]

@antrix1989 Does the authScheme parameter in below method in MSALErrorConvertor.m need to also conform to MSALAuthenticationSchemeProtocolInternal?

+ (NSError *)msalErrorFromMsidError:(NSError *)msidError
                     classifyErrors:(BOOL)shouldClassifyErrors
                 msalOauth2Provider:(MSALOauth2Provider *)oauth2Provider
                            correlationId:(NSUUID *)correlationId
                         authScheme:(id<MSALAuthenticationSchemeProtocol>)authScheme
                         popManager:(MSIDDevicePopManager *)popManager

[stale]

This issue has been automatically marked as stale because it has not had recent activity. Please provide additional information if requested. Thank you for your contributions.

[antrix1989]

@antrix1989 Does the authScheme parameter in below method in MSALErrorConvertor.m need to also conform to MSALAuthenticationSchemeProtocolInternal?

+ (NSError *)msalErrorFromMsidError:(NSError *)msidError
                     classifyErrors:(BOOL)shouldClassifyErrors
                 msalOauth2Provider:(MSALOauth2Provider *)oauth2Provider
                            correlationId:(NSUUID *)correlationId
                         authScheme:(id<MSALAuthenticationSchemeProtocol>)authScheme
                         popManager:(MSIDDevicePopManager *)popManager

We don't use methods of MSALAuthenticationSchemeProtocolInternal there, so it is not needed.