Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ameyapat/spm framework build #1194

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Ameyapat/spm framework build #1194

merged 3 commits into from
Jan 6, 2021

Conversation

ameyapat
Copy link
Contributor

@ameyapat ameyapat commented Jan 6, 2021

Proposed changes

Describe what this PR is trying to do.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@ameyapat ameyapat requested a review from a team as a code owner January 6, 2021 01:34
@ameyapat ameyapat requested review from antrix1989 and kaisong1990 and removed request for a team January 6, 2021 01:34
@ameyapat ameyapat merged commit 2fb6546 into ameyapat/spm-master-test Jan 6, 2021
@oldalton oldalton mentioned this pull request Jan 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antrix1989 antrix1989 Awaiting requested review from antrix1989

@kaisong1990 kaisong1990 Awaiting requested review from kaisong1990

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ameyapat