Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include B2C sample link in readme #1240

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Include B2C sample link in readme #1240

merged 1 commit into from
Feb 12, 2021

Conversation

oldalton
Copy link
Member

Proposed changes

Include B2C sample in the readme for quick access.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@oldalton oldalton requested a review from a team as a code owner February 12, 2021 19:16
kaisong1990
kaisong1990 reviewed Feb 12, 2021
View reviewed changes
README.md
@@ -1,8 +1,8 @@
Microsoft Authentication Library for iOS and macOS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

@oldalton oldalton merged commit 2db704e into dev Feb 12, 2021
@oldalton oldalton deleted the oldalton/update_readme_samples branch February 12, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisong1990 kaisong1990 kaisong1990 approved these changes

@aherciya aherciya Awaiting requested review from aherciya

@hieunguyenmsft hieunguyenmsft Awaiting requested review from hieunguyenmsft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oldalton @kaisong1990