Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to the latest MSAL for throttling unit test #1241

Merged
merged 9 commits into from
Feb 17, 2021
Merged

update to the latest MSAL for throttling unit test #1241

merged 9 commits into from
Feb 17, 2021

Conversation

NerevarineRule
Copy link
Contributor

Proposed changes

Title

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@NerevarineRule NerevarineRule requested a review from a team as a code owner February 17, 2021 01:47
kaisong1990
kaisong1990 reviewed Feb 17, 2021
View reviewed changes
MSAL/IdentityCore
@@ -1 +1 @@
Subproject commit 769b35edc99a5dc6e73c2dde478e89d960052e08
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

@NerevarineRule NerevarineRule merged commit 2fcc224 into dev Feb 17, 2021
@NerevarineRule NerevarineRule deleted the peter/conflictResolution branch February 17, 2021 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisong1990 kaisong1990 kaisong1990 left review comments

@oldalton oldalton oldalton approved these changes

@ameyapat ameyapat Awaiting requested review from ameyapat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NerevarineRule @kaisong1990 @oldalton