Merging #1253 (Remove check if access_token is not returned for id_token only scenarios) #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove check if access_token is not returned for id_token only scenarios
hieunguyenmsft
requested changes
Mar 10, 2021
MSAL/src/MSALResult.m
Outdated
| @@ -135,10 +135,6 @@ + (MSALResult *)resultWithMSIDTokenResult:(MSIDTokenResult *)tokenResult | |||
| } | |||
|
|
|||
| NSString *accessToken = [authScheme getClientAccessToken:tokenResult.accessToken popManager:popManager error:error]; | |||
There was a problem hiding this comment.
To really distinguish the case no accessToken vs parsing accessToken error here, I think we should change to:
if (tokenResult.accessToken is not empty)
{
// parsing access token
} else {
// move on to the next step.
}
kaisong1990
reviewed
Mar 11, 2021
kaisong1990
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Merging a PR from an external contributor: #1253
The PR Azure Pipelines checks are not working for forked repos, so opening a new PR to get PR checks completed.
Type of change
Risk
Additional information