Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release 1.1.16 into dev #1278

Merged
merged 4 commits into from Mar 25, 2021
Merged

Merge release 1.1.16 into dev #1278

merged 4 commits into from Mar 25, 2021

Conversation

antrix1989
Copy link
Contributor

@antrix1989 antrix1989 commented Mar 25, 2021 •
edited

Proposed changes

Describe what this PR is trying to do.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

antrix1989 and others added 4 commits March 16, 2021 15:30
@antrix1989
Create release branch.
ab83e5b
@antrix1989 @shibayan
@oldalton @hieunguyenmsft
Update release branch (#1274)
fcd6055 
* Remove check if access_token is not returned for id_token only scenarios

* Changed properties that depended on accessToken to nullable

* update common lib

* Updated common core

* Updated submodule

* Addressed comments

* Updated submodule

* Return empty access token in MSALResult

* update change log

* Return empty authorization header when access token is empty

* Updated UT

* Updated changelog

* Update common core

* Updated changelog

* Update changelog.

Co-authored-by: Tatsuro Shibamura <me@shibayan.jp>
Co-authored-by: Olga Dalton <oldalton@microsoft.com>
Co-authored-by: HieuNguyen <hiengu@microsoft.com>
Co-authored-by: Hieu Nguyen <65981263+hieunguyenmsft@users.noreply.github.com>
@antrix1989
Update release branch (#1277)
0cdd38b 
* Update common core.

* Trigger new build.
@antrix1989
Merge branch 'release/1.1.16' into sedemche/merge_release_1.1.16_into…
c971913 
…_dev
@antrix1989 antrix1989 requested a review from a team as a code owner March 25, 2021 02:09
@antrix1989 antrix1989 merged commit bae154d into dev Mar 25, 2021
@antrix1989 antrix1989 deleted the sedemche/merge_release_1.1.16_into_dev branch March 25, 2021 02:32
@byohay byohay mentioned this pull request Jun 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisong1990 kaisong1990 kaisong1990 approved these changes

@oldalton oldalton oldalton approved these changes

@Veena11 Veena11 Awaiting requested review from Veena11

@NerevarineRule NerevarineRule Awaiting requested review from NerevarineRule

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antrix1989 @kaisong1990 @oldalton