Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'ts' field in AT Pop payload #1310

Merged
merged 2 commits into from
May 21, 2021
Merged

Update 'ts' field in AT Pop payload #1310

merged 2 commits into from
May 21, 2021

Conversation

hieunguyenmsft
Copy link
Contributor

Proposed changes

Update 'ts' field in AT Pop payload from string to number

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@hieunguyenmsft hieunguyenmsft requested a review from a team as a code owner May 21, 2021 19:59
@hieunguyenmsft hieunguyenmsft changed the base branch from dev to release/1.1.18 May 21, 2021 20:51
@hieunguyenmsft hieunguyenmsft merged commit 7b5157d into release/1.1.18 May 21, 2021
@hieunguyenmsft hieunguyenmsft deleted the hieund/at_pop_cherry_pick branch May 21, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisong1990 kaisong1990 kaisong1990 approved these changes

@jasoncoolmax jasoncoolmax Awaiting requested review from jasoncoolmax

@NerevarineRule NerevarineRule Awaiting requested review from NerevarineRule

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hieunguyenmsft @kaisong1990