Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross cloud support #1370

Merged
merged 7 commits into from
Sep 20, 2021
Merged

Cross cloud support #1370

merged 7 commits into from
Sep 20, 2021

Conversation

jasoncoolmax
Copy link
Member

Proposed changes

This PR updates the common core for cross cloud support.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@jasoncoolmax jasoncoolmax requested a review from a team as a code owner September 2, 2021 05:55
NerevarineRule
NerevarineRule suggested changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@NerevarineRule NerevarineRule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the comment in the common core PR.

@jasoncoolmax
Merge branch 'dev' into jason/crossCloudSupport
1e277d1 
# Conflicts:
#	CHANGELOG.md
#	MSAL/IdentityCore
@jasoncoolmax jasoncoolmax merged commit eee6c7c into dev Sep 20, 2021
@jasoncoolmax jasoncoolmax deleted the jason/crossCloudSupport branch September 20, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oldalton oldalton oldalton approved these changes

@NerevarineRule NerevarineRule NerevarineRule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jasoncoolmax @oldalton @NerevarineRule