Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fastlane plugins #1377

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

kaisong1990
Copy link
Contributor

Proposed changes

Resolve security warnings from github regarding fastlane

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@@ -2,77 +2,97 @@ GEM
remote: https://rubygems.org/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

Copy link
Contributor

@ameyapat ameyapat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the other version changes because of changing addressable version to 2.8.0?

@kaisong1990
Copy link
Contributor Author

Are the other version changes because of changing addressable version to 2.8.0?

There are other dependencies that fastlane used for, so when running fastane update, it just updated all dependencies. There is no issue of running automation so far

@kaisong1990 kaisong1990 merged commit a372e1d into dev Sep 14, 2021
@kaisong1990 kaisong1990 deleted the kaisong1990/update-fastlane-plugins branch September 14, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants