Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update common core submodule that has more string extension methods. #1417

Merged
merged 6 commits into from Dec 3, 2021
Merged

update common core submodule that has more string extension methods. #1417

merged 6 commits into from Dec 3, 2021

Conversation

NerevarineRule
Copy link
Contributor

@NerevarineRule NerevarineRule commented Dec 2, 2021 •
edited

Proposed changes

Based on internal discussion with Olga on this PR: https://github.com/AzureAD/azure-activedirectory-tokenbroker-for-objc/pull/833, updated common core string extension class to have more string APIs, and this MSAL PR updates common core submodule to the commit that has those new changes.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@NerevarineRule NerevarineRule requested a review from a team as a code owner December 2, 2021 23:34
@NerevarineRule NerevarineRule merged commit 923d6d8 into dev Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oldalton oldalton oldalton approved these changes

@antrix1989 antrix1989 Awaiting requested review from antrix1989 antrix1989 is a code owner automatically assigned from AzureAD/appleidentityteam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NerevarineRule @oldalton @antrix1989