Updating common-core for fix in embedded wv #1424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Existing logic to handle navigation in Embedded webview was checking if target frame is main frame. This check was done to open such links in safari as it was understood that such links are meant to open in new tab. Since embedded webview cannot open in new tab, we opened such links in safari.
During sign-up flow for a user, a javascript captcha game is loaded in an iframe to check for robot or spammer. If a user clicks on links in this iframe, existing logic dictates such links to open in safari. This PR aims to correct logic so that links in iframe open in the iframe and not safari while keeping existing functionality of opening links that should open in new tab in safari.
Type of change
Risk
Additional information
Test cases :
Test 1 :
Test 2 :
" prompting to install Authenticator.