Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating common-core for fix in embedded wv #1424

Merged

Conversation

ameyapat
Copy link
Contributor

@ameyapat ameyapat commented Dec 16, 2021

Proposed changes

Existing logic to handle navigation in Embedded webview was checking if target frame is main frame. This check was done to open such links in safari as it was understood that such links are meant to open in new tab. Since embedded webview cannot open in new tab, we opened such links in safari.

During sign-up flow for a user, a javascript captcha game is loaded in an iframe to check for robot or spammer. If a user clicks on links in this iframe, existing logic dictates such links to open in safari. This PR aims to correct logic so that links in iframe open in the iframe and not safari while keeping existing functionality of opening links that should open in new tab in safari.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

Test cases :
Test 1 :

  1. Open iOS MSAL Test App. Set valAuth to NO so that broker is not involved.
  2. Click acquire Token | Sign in page is shown
  3. Click on "Create One!" link. Click on "Get a new email address" link.
  4. Enter any valid email address and password. Follow on-screen instructions and keep clicking next until you reach page with robot puzzle.
  5. On page with title : "Please solve the puzzle so we know you're not a robot." Click Next. | Clicking "Next" button should not open safari. It should load captcha game in webview itself.

Test 2 :

  1. Uninstall MS Authenticator app if installed.
  2. Open MSAL iOS Test App.
  3. Enter email : mfa3@testameya.onmicrosoft.com and password for it.
  4. Keep clicking next until you arrive at page titled : "Keep your account secure
    " prompting to install Authenticator.
  5. Click on "?" on top right of page. | Menu option will expand
  6. Click on "Help" or "Provide feedback" links. | These links should open in safari.

@ameyapat ameyapat requested a review from a team as a code owner December 16, 2021 22:19
@ameyapat ameyapat changed the base branch from dev to ameya-master January 4, 2022 18:52
@ameyapat ameyapat changed the base branch from ameya-master to dev January 4, 2022 18:52
@ameyapat ameyapat merged commit 411b96d into dev Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants