Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for esrp code signing task #1585

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

ameyapat
Copy link
Contributor

Proposed changes

Earlier ESRP codesigning task used to fail because the dotnet version in ADO pipelines was updated and we had to manually switch the dotnet version as a workaround.

ESRP team has released a new version of the task that uses updated dotnet version : https://msazure.visualstudio.com/ESRPSignOnboarding/_workitems/edit/13709241

This PR aims to update the task version and remove the workaround

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@ameyapat ameyapat requested a review from a team as a code owner October 12, 2022 23:31
@@ -102,13 +102,7 @@ jobs:
# Zipping xcframework. -y : including symlinks (Need to preserve symlinks in xcframework so that codesign validation doesn't fail) -v : verbose logging

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

@ameyapat ameyapat merged commit 83685b3 into dev Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants