Add new allowGettingAccessTokenWithRefreshToken in MSALSilentTokenPar… #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameters public API
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
| @@ -872,6 +872,7 @@ - (void)acquireTokenSilentWithParameters:(MSALSilentTokenParameters *)parameters | |||
| msidParams.currentRequestTelemetry.schemaVersion = HTTP_REQUEST_TELEMETRY_SCHEMA_VERSION; | |||
There was a problem hiding this comment.
This pull request does not update CHANGELOG.md.
Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.
9 tasks
juan-arias
reviewed
Oct 26, 2022
juan-arias
approved these changes
Oct 26, 2022
Co-authored-by: Juan Arias <juan-arias@users.noreply.github.com>
antrix1989
reviewed
Oct 27, 2022
antrix1989
reviewed
Nov 3, 2022
| 2. When Sso Extension is not presenting on the device | ||
| This parameter is ignored, and tries with existing refresh token in the cache. | ||
| */ | ||
| @property (nonatomic) BOOL allowGettingAccessTokenWithRefreshToken; |
There was a problem hiding this comment.
This name is confusing. Without reading the comment above, there is no hint this logic applies only when SSO ext is available. Can we change it to something like "useSSOExtRTInsteadOfLocalRT"?
There was a problem hiding this comment.
Updated the same
9 tasks
oldalton
approved these changes
Nov 17, 2022
This was referenced Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ameters public API
Proposed changes
Add new property in MSALSilentTokenParameters public API to allow using local RT as fallback if broker fails
CommonCore change can be found here
Type of change
Risk
Additional information