Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic SSO extension perf telemetry on MSAL side #1593

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

oldalton
Copy link
Member

@oldalton oldalton commented Nov 2, 2022

Proposed changes

Adding basic SSO extension performance telemetry for MSAL.Objective C. Note, it doesn't measure any actual performance inside the broker, it only provides info on MSAL side and sends it to ESTS telemetry. 1DS nor MATS won't give us this insight.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@oldalton oldalton requested a review from a team as a code owner November 2, 2022 04:46
@@ -1 +1 @@
Subproject commit 2ae57daa272bbd2f5108e4ab07f6ac85c08963ba

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

@oldalton oldalton merged commit c0b3271 into dev Nov 4, 2022
@oldalton oldalton deleted the oldalton/sso_ext_perf_telemetry branch November 4, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants