MSAL: Update ios min version to ios 14.0 and macos to 10.13 #1594
Conversation
Veena11
changed the title
Done |
| if (error) *error = msidError; | ||
| return NO; | ||
| } | ||
| NSError *msidError = MSIDCreateError(MSIDErrorDomain, MSIDErrorInvalidDeveloperParameter, @"parentViewController is a required parameter on iOS 13.", nil, nil, nil, nil, nil, YES); |
There was a problem hiding this comment.
Shouldn't this error say ... required parameter on iOS 14 since that's the required minimum now?
There was a problem hiding this comment.
you are right, thanks . I have it fixed in this PR : #1630
|
Is there any reason why iOS 13 could not be supported? I don't see anything specific in the changes |
| @@ -350,7 +350,7 @@ - (void)allAccountsFromDevice:(MSALAccountEnumerationParameters *)parameters | |||
| { | |||
| BOOL shouldCallBroker = NO; | |||
|
|
|||
| if (@available(iOS 13.0, macOS 10.15, *)) | |||
| if (@available(macOS 10.15, *)) | |||
There was a problem hiding this comment.
Shouldn't this be if (@available(iOS 14.0, macOS 10.15, *)) else the code inside the condition would not compile for iOS anymore? The code would only run on macOS since iOS was omitted
There was a problem hiding this comment.
i believe the "*" indicates that the code is also for all other platforms beyond the ones listed . So it should be available for iOS.
There was a problem hiding this comment.
@Veena11 of course! Thanks :) Although is there API required that's no longer going to work on iOS 13? Xcode 14 seems to be otherwise okay with iOS 13 as a minimum target
we intend to support last 3 versions (16, 15, 14) of iOS. |
Proposed changes
Update ios min version to ios 14.0 and macos to 10.13
Type of change
Risk
Additional information