Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leading and trailing spaces From Base64 EncodedString #1598

Merged
merged 5 commits into from
Nov 17, 2022
Merged

Remove leading and trailing spaces From Base64 EncodedString #1598

merged 5 commits into from
Nov 17, 2022

Conversation

Veena11
Copy link
Contributor

@Veena11 Veena11 commented Nov 9, 2022

Proposed changes

Describe what this PR is trying to do.

Remove leading and trailing spaces from bease64 encoded string

  • Feature work
  • [ x] Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@Veena11 Veena11 requested a review from a team as a code owner November 9, 2022 23:03
azure-pipelines[bot]
azure-pipelines bot reviewed Nov 9, 2022
View reviewed changes
MSAL/IdentityCore Outdated
@@ -1 +1 @@
Subproject commit e553e262f9475ff1b2435b6a4ad0b5172450e417
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

@Veena11 Veena11 changed the title remove Leading And Trailing Spaces From Base64 EncodedString Remove leading and trailing spaces From Base64 EncodedString Nov 9, 2022
@Veena11 Veena11 merged commit 8a9f684 into dev Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azure-pipelines azure-pipelines[bot] azure-pipelines left review comments

@juan-arias juan-arias juan-arias approved these changes

@antrix1989 antrix1989 Awaiting requested review from antrix1989 antrix1989 is a code owner automatically assigned from AzureAD/appleidentityteam

@ameyapat ameyapat Awaiting requested review from ameyapat ameyapat is a code owner automatically assigned from AzureAD/appleidentityteam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Veena11 @juan-arias